feat: add allow_missing in the struct_field #1416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xyedo
force-pushed
the
partial-DeserializeValue
branch
from
67e73b9 to
820386a
Compare
github-actions
bot
added
the
semver-checks-breaking
|
See the following report for details: cargo semver-checks output |
There was a problem hiding this comment.
Pull Request Overview
This PR adds an allow_missing attribute to struct fields for both row and value deserialization, allowing fields to be initialized with Default::default() when missing from the database instead of failing. This feature provides compatibility with sqlx's #[sqlx(default)] attribute for smoother migration to scylla-rust-driver.
- Implements
#[scylla(allow_missing)]attribute for both struct-level and field-level usage - Adds support for the attribute in both row and value deserialization contexts
- Includes comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scylla-macros/src/lib.rs | Adds documentation for the new allow_missing attribute |
| scylla-macros/src/serialize/value.rs | Adds ignored allow_missing attribute parsing for value serialization |
| scylla-macros/src/serialize/row.rs | Adds ignored allow_missing attribute parsing for row serialization |
| scylla-macros/src/deserialize/value.rs | Implements allow_missing logic for value deserialization |
| scylla-macros/src/deserialize/row.rs | Implements allow_missing logic for row deserialization |
| scylla/tests/integration/macros/hygiene.rs | Adds hygiene tests for the new attribute |
| scylla-cql/src/deserialize/row_tests.rs | Adds comprehensive tests for allow_missing functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
scylla-macros/src/lib.rs
Outdated
| /// column into the first field, second column into the second field and so on. | ||
| /// It will still still verify that the column types and field types match. | ||
| /// | ||
| /// #[(scylla(allow_missing))] |
There was a problem hiding this comment.
Missing space after # - should be /// #[scylla(allow_missing)]
Suggested change
| /// #[(scylla(allow_missing))] | |
| /// #[scylla(allow_missing)] |
Copilot uses AI. Check for mistakes.
scylla-macros/src/lib.rs
Outdated
| /// to a column with the same name. This attribute allows to match to a column | ||
| /// with provided name. | ||
| /// | ||
| /// #[(scylla(allow_missing))] |
There was a problem hiding this comment.
Missing space after # - should be /// #[scylla(allow_missing)]
Suggested change
| /// #[(scylla(allow_missing))] | |
| /// #[scylla(allow_missing)] |
Copilot uses AI. Check for mistakes.
Xyedo
force-pushed
the
partial-DeserializeValue
branch
from
820386a to
7091295
Compare
add allow_missing with macro DeserializeRow, add allow_missing in the struct attributes to handle partial deserialization and make it easier instead of defining on each struct field
Xyedo
force-pushed
the
partial-DeserializeValue
branch
from
7091295 to
74184aa
Compare
Lorak-mmk
requested changes
Oct 16, 2025
Comment on lines
+185
to
+189
| #[test] | ||
| fn test_struct_deserialization_loose_ordering_allow_missing() { | ||
| #[derive(DeserializeRow, PartialEq, Eq, Debug)] | ||
| #[scylla(crate = "crate")] | ||
| #[scylla(allow_missing)] |
There was a problem hiding this comment.
Please let's do one thing in this PR. Other field attributes can't be used on a struct, so let's remove this ability from this one as well, at least for now. It will also simplify this PR a lot.
Lorak-mmk
added
the
waiting-on-author
wprzytula
requested changes
Oct 17, 2025
| /// If set, the generated implementation will not verify the column names at | ||
| /// all. Because it only works with `enforce_order`, it will deserialize first | ||
| /// column into the first field, second column into the second field and so on. | ||
| /// It will still still verify that the column types and field types match. |
There was a problem hiding this comment.
🏕️ Unrelated to this PR - typo: still still -> still.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1146
it also make it migrating from #[sqlx(default)] to scylladb #[scylla(allow_missing)] smoothly
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.